Repository navigation
fix(site): the read API page fits its weight budget again, and CI checks the budget before merge - #35
Merged
Merged
Conversation
…e deploys /docs/api/read is 30.3KB brotli with the weight edit and checkpoint fields from #32, over its 30KB budget, which stopped the Site workflow before the deploy. The page is part of the generated API reference and grows with the tool, so its budget goes to 33KB, about 10% over what it measures.
…the deploy The budget ran only in the Site workflow on main, so #32 passed CI and then stopped the deploy. CI now runs it after the site build, on the Linux Node 24 leg, the same OS and Node as the Site workflow.
Owner
Author
|
Correction to the description: "the site has not deployed since #32" overstates it. The Site workflow failed at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site has not deployed since #32 merged. The Site workflow stops at its
Perf budgetstep:/docs/api/read/is 30.3KB brotli against a 30.0KB budget. The page is the part of the generated API reference that gained the weight edit and checkpoint fields.What changes
/docs/api/read/goes from 30KB to 33KB inapps/site/scripts/perf-budget.mjs, about 10% over what the page measures, the same rule the other generated reference pages follow.npm run perf:budgetafter the site build on the Linux Node 24 leg, the same OS and Node as the Site workflow. The step took 22 seconds in the Site workflow.docs/perf.mdsays where the budget runs.Two commits, one per change.
Checks
FAIL /docs/api/read/: HTML is 30.3KB brotli, budget 30.0KB. The new script on the same build:perf-budget: ok, closest page/docs/agents/at 25.1KB of 26.0KB.actionlint -shellcheck= .github/workflows/*.yml: clean.npm run lint: clean. Docs tests: 51 of 51.Not checked locally